Handle asyncio's Task cancellation and aiohttp's websock close properly #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciscorn
changed the title
ciscorn
commented
Jun 2, 2018
| for task in pending_tasks: | ||
| if not task.done(): | ||
| task.cancel() | ||
| await wait(pending_tasks, loop=self.loop) |
There was a problem hiding this comment.
All pending tasks should be cancelled and awaited.
ciscorn
commented
Jun 2, 2018
| elif msg.type == WSMsgType.CLOSING: | ||
| raise ConnectionClosedException() | ||
| elif msg.type == WSMsgType.CLOSED: | ||
| raise ConnectionClosedException() |
There was a problem hiding this comment.
The original code raises ConnectionClosedException only when msg.type == WSMsgType.ERROR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation doesn’t manage asyncio.Task and aiohttp.WebSocketResponce properly, which causes the following errors frequently.
This problem also prevents the app from performing graceful shutdown/reloading in some situations.