Unbreakable flask_gevent subscription resolving

[fallguard]

• GraphQL AioWS version: Flask==1.1.2 Flask-Sockets==0.2.1 graphene==2.1.8 graphql-ws==0.3.1
• Python version: 3.7.3
• Operating System: Windows x64

Description

I checked the flask_gevent example and finded out the resolve stream does not ended when client is disconnected.

I mean the lambda inside of this

    def resolve_random_int(root, info):
        return Observable.interval(1000).map(lambda i: RandomType(seconds=i, random_int=random.randint(0, 500)))

continues be called every 1000 ms after a client breaks ws connection.

Is there way to break resolving somehow? I want to a client be subscribed all time and got a new portion of data time by time

[SmileyChris]

I'm just tidying up a refactor branch and I tested against it, and it fixes this :) Should get it out in the next few days.

…

On Thu, 25 Jun 2020 at 17:24, fallguard ***@***.***> wrote: - GraphQL AioWS version: Flask==1.1.2 Flask-Sockets==0.2.1 graphene==2.1.8 graphql-ws==0.3.1 - Python version: 3.7.3 - Operating System: Windows x64 Description I checked the flask_gevent example and finded out the resolve stream does not ended when client is disconnected. I mean the lambda inside of this def resolve_random_int(root, info): return Observable.interval(1000).map(lambda i: RandomType(seconds=i, random_int=random.randint(0, 500))) continues be called every 1000 ms after a client breaks ws connection. Is there way to break resolving somehow? I want to a client be subscribed all time and got a new portion of data time by time — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#48>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA2274D24Z3RBLW3ZZR5MLRYLNQFANCNFSM4OH34Y3A> .

[fallguard]

Great, thanks. I'll wait for the fix

[SmileyChris]

@fallguard go look at #46 -- it's marked draft but it's 99% of the way there now. If you can do a review of that branch (even just checking out the branch and reporting how it works) then that would be helpful!

[fallguard]

@SmileyChris I just checked the branch and yes, it fixes the issue