Skip to content

Implement __hash__ for GraphQLError #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 31, 2019
Merged

Implement __hash__ for GraphQLError #35

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
afdf9df
Implement __hash__ for GraphQLError
andrew-humu May 30, 2019
dac9396
Add unit test
andrew-humu May 30, 2019
5a60046
Preserve superclass hash functionality
andrew-humu May 31, 2019
ac63f96
Don't try to support python 2
andrew-humu May 31, 2019
d2121cc
Clarify test assertions
andrew-humu May 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions graphql/error/graphql_error.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ def __eq__(self, other):
)
)

def __hash__(self):
return super(GraphQLError, self).__hash__()

def __ne__(self, other):
return not self.__eq__(other)

Expand Down
9 changes: 9 additions & 0 deletions tests/error/test_graphql_error.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,3 +126,12 @@ def default_error_formatter_includes_extension_fields():
"path": None,
"extensions": {"foo": "bar"},
}

def is_hashable():
e = GraphQLError("msg", extensions={"foo": "bar"})
assert hash(e) is not Nonw

def hashes_are_unique():
e1 = GraphQLError("msg", extensions={"foo": "bar"})
e2 = GraphQLError("msg", extensions={"foo": "bar"})
assert hash(e1) != hash(e2)