Road to v0.6.0 #70
Road to v0.6.0 #70
Conversation
|
I have also started working on graphql/graphql-js@e6e8d19 but it turns out that is not such an easy thing because of the way So it always returns a Both of them break a lot of other unit tests, so not sure what the best approach forward is for this. Fixing all of the tests or just ignoring this commit. |
|
Ok it actually wasn't too difficult to fix.Getting through the commits. Only 7 left. |
…r than fragment AST node. Commit: graphql/graphql-js@688a1ee
|
@syrusakbary All commits are now moved over. For some reason my local |
|
Sweet, got all tests passing :) |
|
Hi Markus! Thanks for your great work! If you could make another PR for the |
|
@syrusakbary will do asap :) |
|
@syrusakbary Merged in next branch, changed this PR (so did not have to open up a new one) and all tests are passing. |
| @@ -643,12 +662,14 @@ def parse_argument_defs(parser): | |||
| def parse_input_value_def(parser): | |||
| start = parser.token.start | |||
|
|
|||
| return ast.InputValueDefinition( | |||
| bla = ast.InputValueDefinition( | |||
There was a problem hiding this comment.
Oh yes haha. Thank you for catching that @syrusakbary. That is one of my typical debugging variable names. Especially when I feel quite uncreative.
|
Looking good 👍 |
I thought I'd get started on the work to
0.6.0. These are the list of commits we need: graphql/graphql-js@v0.5.0...v0.6.0It seems some of those had already been done so I just added small bits as I thought necessary. Other than that I basically just added the suggestion of other graphql fields so far (That means all commit are done until and including #ec05b54)
Doesn't seem to be a huge milestone this time.