Skip to content

Add to unit tests to ensure test accepts both edits of enter and leave #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2016
Merged

Add to unit tests to ensure test accepts both edits of enter and leave #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions graphql/language/tests/test_visitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,13 @@ def test_allows_editing_a_node_both_on_enter_and_on_leave():
ast = parse('{ a, b, c { a, b, c } }', no_location=True)

class TestVisitor(Visitor):
def __init__(self):
self.did_enter = False
self.did_leave = False

def enter(self, node, *args):
if isinstance(node, OperationDefinition):
self.did_enter = True
selection_set = node.selection_set
self.selections = None
if selection_set:
Expand All @@ -33,6 +38,7 @@ def enter(self, node, *args):

def leave(self, node, *args):
if isinstance(node, OperationDefinition):
self.did_leave = True
new_selection_set = None
if self.selections:
new_selection_set = SelectionSet(
Expand All @@ -45,9 +51,12 @@ def leave(self, node, *args):
operation=node.operation,
selection_set=new_selection_set)

edited_ast = visit(ast, TestVisitor())
visitor = TestVisitor()
edited_ast = visit(ast, visitor)
assert ast == parse('{ a, b, c { a, b, c } }', no_location=True)
assert edited_ast == ast
assert visitor.did_enter
assert visitor.did_leave


def test_allows_editing_the_root_node_on_enter_and_on_leave():
Expand All @@ -56,20 +65,29 @@ def test_allows_editing_the_root_node_on_enter_and_on_leave():
definitions = ast.definitions

class TestVisitor(Visitor):
def __init__(self):
self.did_enter = False
self.did_leave = False

def enter(self, node, *args):
if isinstance(node, Document):
self.did_enter = True
return Document(
loc=node.loc,
definitions=[])

def leave(self, node, *args):
if isinstance(node, Document):
self.did_leave = True
return Document(
loc=node.loc,
definitions=definitions)

edited_ast = visit(ast, TestVisitor())
visitor = TestVisitor()
edited_ast = visit(ast, visitor)
assert edited_ast == ast
assert visitor.did_enter
assert visitor.did_leave


def test_allows_for_editing_on_enter():
Expand Down