-
Notifications
You must be signed in to change notification settings - Fork 181
Travis uses tox #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis uses tox #188
Conversation
py27 and pypy are failing due to graphql-python/graphql-core#189 - I think it makes sense to fix that as a separate branch then circle back to this one when it's resolved to prevent this branch getting even more enormous. edit fix is over at graphql-python/graphql-core#190 |
@syrusakbary I've resolved merge conflicts with latest master. What do you think of merging this in? I think it makes the travis behavior easier to understand and also contributers who run |
I'm working on adding static type checking. Since it will probably merge conflicts between this two branches (as this is also formatting some code), I will wait to merge. |
If you want to rebase from master I will happily review this PR again :) |
@syrusakbary OK will do! I still think having pre-commit (which runs flake8 and other checks) run as part of travis will help maintain good code quality. I'll see about updating this one tonight. |
@syrusakbary this is ready for a review. |
Travis runs various tox environments to do testing.
In addition:
a. isort added in A possible minor bug in ExecutionContext.complete_value graphql-core#187
b. flake8 added in Can you inject fields to an operation with a Visitor? graphql-core#191