Skip to content

Travis uses tox #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 6, 2018
Merged

Conversation

dan98765
Copy link
Collaborator

@dan98765 dan98765 commented Jun 9, 2018

Travis runs various tox environments to do testing.

In addition:

  1. Drop py33 support
  2. Do not run flake8 or isort as part of tox; those are taken care of via pre-commit;
    a. isort added in A possible minor bug in ExecutionContext.complete_value graphql-core#187
    b. flake8 added in Can you inject fields to an operation with a Visitor? graphql-core#191

@dan98765
Copy link
Collaborator Author

dan98765 commented Jun 9, 2018

py27 and pypy are failing due to graphql-python/graphql-core#189 - I think it makes sense to fix that as a separate branch then circle back to this one when it's resolved to prevent this branch getting even more enormous.

edit fix is over at graphql-python/graphql-core#190

@dan98765
Copy link
Collaborator Author

@syrusakbary I've resolved merge conflicts with latest master. What do you think of merging this in? I think it makes the travis behavior easier to understand and also contributers who run tox will end up getting the same behavior as travis so no surprises. It'll also match graphene with graphql-python/graphene#737

@syrusakbary
Copy link
Member

I'm working on adding static type checking. Since it will probably merge conflicts between this two branches (as this is also formatting some code), I will wait to merge.

graphql-python/graphql-core#193

@syrusakbary
Copy link
Member

If you want to rebase from master I will happily review this PR again :)

@dan98765
Copy link
Collaborator Author

dan98765 commented Jul 5, 2018

@syrusakbary OK will do! I still think having pre-commit (which runs flake8 and other checks) run as part of travis will help maintain good code quality. I'll see about updating this one tonight.

@dan98765
Copy link
Collaborator Author

dan98765 commented Jul 6, 2018

@syrusakbary this is ready for a review.

@syrusakbary syrusakbary merged commit 91fb8c2 into graphql-python:master Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants