Handle serialization of standard library Enum values #140
Conversation
|
After additional review, I realized that pyutils.enum exists only in graphene, not graphql-core. I removed the fallback if the standard library Enum can't be found and reverted to the original behavior in this case. I think it should be possible to have graphene's pyutils.enum implement collections.Hashable, which would make it compatible with this code, but I'm not very familiar with metaclasses and I wasn't successful trying to add this myself. |
|
This seems more right to me than the other proposals I found at graphql-python/graphene#559 and graphql-python/graphql-core#139. I'd be in favor of merging something like this |
|
Upon review, this looks great to me. Happy to bin #139 for this. |
|
Will this ever get merged? |
…gREST calls replaced with GraphQL ones Also circumvent the bug we face with Graphene Python Enums (@link graphql-python/graphql-core#140)
syrusakbary
force-pushed
the
master
branch
3 times, most recently
from
b1f26c1 to
a7ce75e
Compare
|
I'm fixing few issues and merging it soon, so it will be released in |
This is my attempt at fixing graphql-python/graphene#547. dpnova's patch (#139) apparently breaks when GraphQLEnumType.serialize() is called with a value that is not an Enum instance, although I'm not sure when that happens, since it doesn't seem to be the case with GraphQL Enum types. This patch checks if the value is an Enum instance first, and retains the current behavior if not.