Skip to content

Revert the removal of the _value postfix in the graphql() function #234

Closed
@Cito

Description

@Cito

In f6d79ab, the _value postfix of some of the graphql() parameters has been removed and gives a deprecation warning now.

I propose to revert that change (and reverse the deprecation message, i.e. display it now for the shorter names instead), because:

  • We want to be as compatible with GraphQL.js (the "GraphQL reference implementation") as possible, including the naming. This makes it easier for us to keep in sync with GraphQL.js in the future and for developers to translate examples directly from JavaScript to Python (you only need to translate from camelCase to snake_case, but not change names).
  • The _value postfix still exists in the ExecutionContext which is inconsistent
  • graphql-core-next and graphql-core/modern branch also use the names with the _value postfix

If we believe the _value postfix is really stupid and unnecessary or want to make other name changes, then please in the future let's first try to convice the GraphQL.js people (who are nice and responsive) to make that change there, and then we can replicate it in Python.

@syrusakbary - what do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions