Skip to content

Fix assert message in Register class. Fixes #91. #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Fix assert message in Register class. Fixes #91. #92

merged 1 commit into from
Nov 22, 2017

Conversation

geertjanvdk
Copy link

Previously, when trying to register an ObjectType which is not supported by Registry-class, an AttributeError is raised instead of AssertError.

We correct the problem by making sure we do not call format() on a tuple.

Tests were added for the Registry.register() method.

@coveralls
Copy link

coveralls commented Nov 21, 2017

Coverage Status

Coverage remained the same at 90.813% when pulling 80f1a6b on geertjanvdk:fix/91 into 136d2b3 on graphql-python:master.

@syrusakbary syrusakbary merged commit 166f552 into graphql-python:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants