Skip to content

sqlalchemy-type Biginteger cannot be handled as graphql-type integer because it is limited to 32 bit #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 23, 2016

Conversation

palmkevin
Copy link
Contributor

According to the standard, the graphql-int-type is limited to 32 bit.
But BigInteger in sqlalchemy can contain greater numeric values...

I changed the converter in order to convert BigInteger to float instead of int and this seems to work without any drawback

@coveralls
Copy link

coveralls commented Nov 18, 2016

Coverage Status

Coverage remained the same at 90.295% when pulling f83e406 on palmkevin:BigInteger into c07b746 on graphql-python:master.

@palmkevin
Copy link
Contributor Author

palmkevin commented Nov 18, 2016

Sorry for this messy pull request. I am new to git...
b8a4c8e does not belong to this request... how can I remove it? Edit: I figured it out myself

@coveralls
Copy link

coveralls commented Nov 18, 2016

Coverage Status

Coverage remained the same at 90.295% when pulling b8a4c8e on palmkevin:BigInteger into c07b746 on graphql-python:master.

@coveralls
Copy link

coveralls commented Nov 21, 2016

Coverage Status

Coverage remained the same at 90.295% when pulling 8b2fea5 on palmkevin:BigInteger into c07b746 on graphql-python:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.295% when pulling 8b2fea5 on palmkevin:BigInteger into c07b746 on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.295% when pulling 8b2fea5 on palmkevin:BigInteger into c07b746 on graphql-python:master.

@syrusakbary syrusakbary merged commit cb974e9 into graphql-python:master Nov 23, 2016
@palmkevin palmkevin deleted the BigInteger branch November 23, 2016 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants