Skip to content

Add istore as pre-commit hook #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

Nabellaleen
Copy link
Collaborator

As suggested in https://github.com/pre-commit/mirrors-isort , I also added an automatic pre-computing of known third party by using https://github.com/asottile/seed-isort-config

@Nabellaleen Nabellaleen added this to the 2.1.1 milestone Mar 30, 2019
@Nabellaleen Nabellaleen requested a review from jnak March 30, 2019 22:59
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.899% when pulling d8f657a on Nabellaleen:precommit-isort into 1033de5 on graphql-python:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.899% when pulling d8f657a on Nabellaleen:precommit-isort into 1033de5 on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.899% when pulling d8f657a on Nabellaleen:precommit-isort into 1033de5 on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.899% when pulling d8f657a on Nabellaleen:precommit-isort into 1033de5 on graphql-python:master.

@coveralls
Copy link

coveralls commented Mar 30, 2019

Coverage Status

Coverage remained the same at 91.899% when pulling bf28813 on Nabellaleen:precommit-isort into 1033de5 on graphql-python:master.

Copy link
Collaborator

@jnak jnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tend to prefer absolute imports so this feels like a slight regression to me. But that does not really matter as long as we are consistent across the repo.

@jnak jnak merged commit 25dd3d0 into graphql-python:master Apr 1, 2019
@Nabellaleen Nabellaleen deleted the precommit-isort branch April 1, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants