Skip to content

Re-enable linters as pre-commit hooks #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2019

Conversation

jnak
Copy link
Collaborator

@jnak jnak commented Mar 29, 2019

Fix #189
I also looked into adding back isort but that unfortunately it's not trivial to make it work with pre-commit hooks. I'll take another pass at it next week.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.899% when pulling 98ae3a3 on jnak:travis-lint into c3f175f on graphql-python:master.

7 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.899% when pulling 98ae3a3 on jnak:travis-lint into c3f175f on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.899% when pulling 98ae3a3 on jnak:travis-lint into c3f175f on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.899% when pulling 98ae3a3 on jnak:travis-lint into c3f175f on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.899% when pulling 98ae3a3 on jnak:travis-lint into c3f175f on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.899% when pulling 98ae3a3 on jnak:travis-lint into c3f175f on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.899% when pulling 98ae3a3 on jnak:travis-lint into c3f175f on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.899% when pulling 98ae3a3 on jnak:travis-lint into c3f175f on graphql-python:master.

@Nabellaleen
Copy link
Collaborator

@jnak : I think coveralls should only be computed for py37 to avoid the spamming on PR 😂

@Nabellaleen Nabellaleen merged commit 1033de5 into graphql-python:master Mar 30, 2019
@jnak
Copy link
Collaborator Author

jnak commented Apr 1, 2019

@Nabellaleen Yep makes sense. Working on it now.

@Nabellaleen Nabellaleen added this to the 2.1.1 milestone Apr 1, 2019
@jnak
Copy link
Collaborator Author

jnak commented Apr 1, 2019

@Nabellaleen It looks like there is a setting to disable notifications on PRs in the coveralls admin but only the owner of the repo has access to it. Do you know who that person is?

See:
https://docs.coveralls.io/coveralls-notifications
lemurheavy/coveralls-public#88 (comment)
https://coveralls.io/github/graphql-python/graphene-sqlalchemy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants