-
Notifications
You must be signed in to change notification settings - Fork 227
Re-enable linters as pre-commit hooks #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7 similar comments
@jnak : I think coveralls should only be computed for py37 to avoid the spamming on PR 😂 |
@Nabellaleen Yep makes sense. Working on it now. |
@Nabellaleen It looks like there is a setting to disable notifications on PRs in the See: |
Fix #189
I also looked into adding back
isort
but that unfortunately it's not trivial to make it work with pre-commit hooks. I'll take another pass at it next week.