Skip to content

Update converter.py again to include INET and CIDR types. #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2018
Merged

Update converter.py again to include INET and CIDR types. #105

merged 1 commit into from
Feb 9, 2018

Conversation

scotmatson
Copy link
Contributor

Type coverage for this is poor and needs to address a wider array of types provided by SQLAlchemy.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 91.034% when pulling 6220e25 on scotmatson:patch-2 into 4827ce2 on graphql-python:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 91.034% when pulling 6220e25 on scotmatson:patch-2 into 4827ce2 on graphql-python:master.

@coveralls
Copy link

coveralls commented Dec 20, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 91.034% when pulling 6220e25 on scotmatson:patch-2 into 4827ce2 on graphql-python:master.

@scotmatson
Copy link
Contributor Author

This PR replaces my previous PR of the same issue, #69 which began failing changes in the code base following the request.

@syrusakbary syrusakbary merged commit 6e4b721 into graphql-python:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scotmatson @coveralls @syrusakbary