Skip to content

Use the Django TestCase's Client #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tnightingale
Copy link
Contributor

Use the django.test.Client instance that Django provides with its TestCase class.

This allows GraphQL tests to make use of the stateful client methods like client.login().

… its TestCase class. This allows GraphQL tests to make use of the stateful client methods like login()
@ulgens
Copy link
Collaborator

ulgens commented May 19, 2020

ping @jkimbo

@ulgens ulgens requested review from ulgens and jkimbo May 19, 2020 00:40
@tnightingale tnightingale requested a review from ulgens May 19, 2020 23:43
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change @tnightingale but the automated tests are failing. Can you fix them?

@stale
Copy link

stale bot commented Aug 27, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Aug 27, 2020
@ulgens ulgens removed the wontfix label Aug 28, 2020
@ulgens ulgens self-assigned this Aug 28, 2020
@ulgens
Copy link
Collaborator

ulgens commented Nov 10, 2020

@tnightingale @zbyte64 Any change we rebase & merge this?

@zbyte64
Copy link
Collaborator

zbyte64 commented Nov 20, 2020

Looks like graphene_django/tests/test_utils.py needs to be updated to reference GraphqlTestCase? Seeing ModuleNotFoundError: No module named 'graphene_django.utils.testing.Client'; 'graphene_django.utils.testing' is not a package

Not sure how master is passing but this does not...

@ulgens
Copy link
Collaborator

ulgens commented Dec 31, 2020

This PR can be closed, thanks to #1084

@zbyte64 zbyte64 closed this Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants