Skip to content

Updated Basic-Tutorial with Highlights ✨✨✨ #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

athul
Copy link
Contributor

@athul athul commented Oct 18, 2019

Due to the Limitations in Sphinx, I had to create another file in the Docs for Highlighting the Changes. Now The new code is Highlighted with the new additions .

Screen Shot 2019-10-18 at 7 59 06 PM

This Resolves #798 in some manner

@zbyte64
Copy link
Collaborator

zbyte64 commented Oct 18, 2019

This adds the ability to highlight, but the example is missing the markup, correct?

@athul
Copy link
Contributor Author

athul commented Oct 19, 2019

This is due to a limitation in Sphinx's literalinclude. Just to emphasise or highlight the file, A new file has to be loaded while building the Docs and schema.py is used for it.

The above screenshot has been cropped from the html files. The code is shown in the webpage with the line highlight.
Here is the original one

image

@ProjectCheshire ProjectCheshire merged commit e51e602 into graphql-python:master Oct 31, 2019
JianyuTANG added a commit to JianyuTANG/graphene-django that referenced this pull request Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the Docs with a diff view
3 participants