Skip to content

Handle isnull filters differently #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2019
Merged

Handle isnull filters differently #753

merged 2 commits into from
Sep 22, 2019

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Aug 18, 2019

Fixes #750

@martasd
Copy link

martasd commented Sep 3, 2019

What is the status on this PR? This is a very important functionality. Could you please merge?

@mvanlonden
Copy link
Member

@jkimbo is this ready to merge?

@jkimbo jkimbo requested a review from zbyte64 September 22, 2019 19:47
@jkimbo
Copy link
Member Author

jkimbo commented Sep 22, 2019

Since this is a bugfix I'm going to merge this without approvals. Any objections please comment here and we can fix it in another PR.

@jkimbo jkimbo merged commit e4cf59e into master Sep 22, 2019
@jkimbo jkimbo deleted the bugfix/filter-fields-type branch September 22, 2019 20:15
@martasd
Copy link

martasd commented Oct 2, 2019

Hi. I am still seeing the same issue with the isnull filter from #750 even after upgrading to 2.6. Has it really been fixed?

@martasd
Copy link

martasd commented Oct 10, 2019

I take my question back. I do not see the issue anymore. Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Supposedly wrong types in query with filter_fields since 2.4.0
4 participants