#63 Get name of reverse_fields from model.dict #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

syrusakbary merged 2 commits into graphql-python:master from momamene:fix-reverse-fields-name

Mar 16, 2017

Contributor

momamene commented Dec 13, 2016

If related name is not set, graphene-django cannot find reverse related objects.

It is because default_resolver in graphene.typemap just get attname from root.

Actually, the name of related objects in django model is assigned as get_accessor_name, not just name or attname.

So it is needed to get name from information of model.__dict__.items, not field.name.

By modifiing like this, schema can find the corresponding related field name containing the _set suffix.

coveralls commented Dec 13, 2016

Coverage decreased (-3.2%) to 89.206% when pulling eb8d929 on momamene:fix-reverse-fields-name into 94bab46 on graphql-python:master.

momamene force-pushed the fix-reverse-fields-name branch from eb8d929 to 534f61c Compare

December 14, 2016 08:05

coveralls commented Dec 14, 2016

Coverage increased (+0.009%) to 92.45% when pulling 534f61c on momamene:fix-reverse-fields-name into 94bab46 on graphql-python:master.

2 similar comments

coveralls commented Dec 14, 2016

Coverage increased (+0.009%) to 92.45% when pulling 534f61c on momamene:fix-reverse-fields-name into 94bab46 on graphql-python:master.

coveralls commented Dec 14, 2016 •

edited

Loading

Coverage increased (+0.009%) to 92.45% when pulling 534f61c on momamene:fix-reverse-fields-name into 94bab46 on graphql-python:master.

momamene force-pushed the fix-reverse-fields-name branch from 534f61c to 6d988f4 Compare

December 14, 2016 08:12


          Get name of reverse_fields from model.__dict__

8bb55ed

momamene force-pushed the fix-reverse-fields-name branch from 6d988f4 to 8bb55ed Compare

December 14, 2016 08:14

coveralls commented Dec 14, 2016 •

edited

Loading

Coverage remained the same at 92.441% when pulling 6d988f4 on momamene:fix-reverse-fields-name into 94bab46 on graphql-python:master.

4 similar comments

coveralls commented Dec 14, 2016

Coverage remained the same at 92.441% when pulling 6d988f4 on momamene:fix-reverse-fields-name into 94bab46 on graphql-python:master.

coveralls commented Dec 14, 2016

Coverage remained the same at 92.441% when pulling 6d988f4 on momamene:fix-reverse-fields-name into 94bab46 on graphql-python:master.

coveralls commented Dec 14, 2016

Coverage remained the same at 92.441% when pulling 6d988f4 on momamene:fix-reverse-fields-name into 94bab46 on graphql-python:master.

coveralls commented Dec 14, 2016

Coverage remained the same at 92.441% when pulling 6d988f4 on momamene:fix-reverse-fields-name into 94bab46 on graphql-python:master.

coveralls commented Dec 14, 2016 •

edited

Loading

Coverage decreased (-0.009%) to 92.432% when pulling 8bb55ed on momamene:fix-reverse-fields-name into 94bab46 on graphql-python:master.


          Remove meaningless guard

45542b6

coveralls commented Dec 14, 2016 •

edited

Loading

Coverage increased (+0.1%) to 92.537% when pulling 45542b6 on momamene:fix-reverse-fields-name into 94bab46 on graphql-python:master.

Member

syrusakbary commented Dec 15, 2016

Great PR! I think is quite useful.

However if we can cover this case with a new test case would be great, as it assures this issue will not happen in the future!

Member

syrusakbary commented Jan 15, 2017

@momamene let me know if you want to add a test case, or you need some assistance from me :)

syrusakbary merged commit eb02f87 into graphql-python:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet