Skip to content

Support required=True for DjangoFilterConnectionFields #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support required=True for DjangoFilterConnectionFields #711

wants to merge 1 commit into from

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Jul 13, 2019

Fixes #700

@jkimbo jkimbo requested review from zbyte64, phalt and dopeboy July 13, 2019 10:23
@jkimbo jkimbo mentioned this pull request Jul 13, 2019
Closed
zbyte64
zbyte64 requested changes Jul 19, 2019
View reviewed changes
Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see a test cover what happens when they don't request a required connection field.

graphene_django/tests/test_fields.py
pytestmark = pytest.mark.django_db


def test_required_connection_field():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between this test and test_required_filter_field ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zbyte64 this test uses a DjangoConnectionField while the other test uses a DjangoFilterConnectionField

@jackton1 jackton1 mentioned this pull request Jul 26, 2019
Closed
@jkimbo
Copy link
Member Author

jkimbo commented Aug 1, 2019

Looks like this got fixed in #610

@jkimbo jkimbo closed this Aug 1, 2019
@ulgens ulgens deleted the bugfix/filter-connection-required branch December 31, 2020 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbyte64 zbyte64 zbyte64 requested changes

@phalt phalt Awaiting requested review from phalt

@dopeboy dopeboy Awaiting requested review from dopeboy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required DjangoFilterConnectionField has "no _meta attribute" error.
2 participants
@jkimbo @zbyte64