Fix some mistakes in documentation #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ingredients` and `recipes` from [examples/cookbook](https://github.com/graphql-python/graphene-django/tree/master/examples/cookbook) are included in cookbook/cookbook. By following the tutorial `ingredients` and `recipes` are in `cookbook/`. Two possibilities : 1) There is a mistake in the doc and I can correct it by adding a `cd cookbook` (as done by the PR) 2) Correct the [examples/cookbook](https://github.com/graphql-python/graphene-django/tree/master/examples/cookbook). Solution 1 is easier but I prefer the solution 2 because it is closer of what is done in the [django tutorial](https://docs.djangoproject.com/en/1.10/intro/tutorial01/).
The `PostNode` class uses as model Post which does not have any field `title`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves two mistakes in the doc :
PostNodeclass uses as model Post which does not have any fieldtitleingredientsandrecipesdirectories from examples/cookbook are included in cookbook/cookbook.By following the tutorial
ingredientsandrecipesare incookbook/.For the second problem there is two possibilities :
cd cookbook(as done by the PR)Solution 1 is easier but I prefer the solution 2 because it is closer of what is done in the django tutorial. This PR implements the solution 1 but I can change if necessary.