Skip to content

Adds documentation to CAMELCASE_ERRORS setting #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2019

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Jun 25, 2019

Following on from #514 this PR renames the setting to CAMELCASE_ERRORS (the DJANGO_GRAPHENE part was unnecessary since it's in the GRAPHENE setting already) and adds documentation for the setting.

FYI @kalekseev

Copy link
Contributor

@phalt phalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking that this will be a breaking change, I assume it is going into the 3.x release?

@kalekseev
Copy link
Contributor

@phalt do you see a way how it can break? We were trying to prevent that with that new option, by default it's off so it shouldn't affect old code.

@jkimbo
Copy link
Member Author

jkimbo commented Jun 25, 2019

@phalt the original PR #514 was just merged and hasn't been released yet. Also because the functionality is setup to be an option (that defaults to the previous behaviour) this isn't a breaking change.

@jkimbo jkimbo merged commit 0988e07 into master Jul 8, 2019
@jkimbo jkimbo deleted the document-camelcase-errors branch July 8, 2019 21:22
@jkimbo jkimbo mentioned this pull request Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants