Skip to content

Make cookbook example working on django 2 #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2019
Merged

Make cookbook example working on django 2 #680

merged 1 commit into from
Jun 19, 2019

Conversation

artofhuman
Copy link
Contributor

This PR updates Django version for cookbook example

@artofhuman artofhuman force-pushed the fix-cookbook-example branch from 3189892 to ab34a11 Compare June 18, 2019 18:58
@artofhuman artofhuman force-pushed the fix-cookbook-example branch from ab34a11 to ae05dee Compare June 18, 2019 19:37
phalt
phalt reviewed Jun 19, 2019
View reviewed changes
Copy link
Contributor

@phalt phalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, have you tested that this works okay?

@artofhuman
Copy link
Contributor Author

Yes, tested using graphiql

jkimbo
jkimbo approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks @artofhuman

@jkimbo jkimbo requested review from dopeboy, patrick91 and zbyte64 June 19, 2019 10:05
@phalt phalt merged commit 91c1278 into graphql-python:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phalt phalt phalt approved these changes

@jkimbo jkimbo jkimbo approved these changes

@dopeboy dopeboy Awaiting requested review from dopeboy

@patrick91 patrick91 Awaiting requested review from patrick91

@zbyte64 zbyte64 Awaiting requested review from zbyte64

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artofhuman @phalt @jkimbo