-
Notifications
You must be signed in to change notification settings - Fork 767
Update mutations.rst #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update mutations.rst #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the `[1]` was ommitted from the `from_global_id` call as that method returns a tuple of type and id, of which we're only interested in the id here. Took me half a day to figure out why this code wasn't working today. See function def here: https://github.com/graphql-python/graphql-relay-py/blob/master/graphql_relay/node/node.py#L67
phalt
approved these changes
Jun 6, 2019
While we're here, the same code example starts with import graphene import relay, DjangoObjectType
from graphql_relay import from_global_id This should probably be expanded to import graphene
from graphene import relay
from graphene_django import DjangoObjectType
from graphql_relay import from_global_id |
@clarkmoody That's a good point, thanks for catching that. That was something else I dealt with yesterday. I can make that fix as well. |
Per comment here: graphql-python#657 (comment)
phalt
approved these changes
Jun 7, 2019
keithshapiro0418
added a commit
to keithshapiro0418/graphene-django
that referenced
this pull request
Mar 21, 2021
floresarmida
added a commit
to floresarmida/graphene-django
that referenced
this pull request
Dec 22, 2021
redhawkIT
added a commit
to redhawkIT/graphene-django
that referenced
this pull request
Dec 22, 2021
rylanhall33
added a commit
to rylanhall33/graphene-django
that referenced
this pull request
Jun 15, 2022
tylerc2023
added a commit
to tylerc2023/graphene-django
that referenced
this pull request
Sep 8, 2022
stevanovicmilan839
added a commit
to stevanovicmilan839/graphene-django
that referenced
this pull request
Nov 2, 2022
VV-YY
added a commit
to VV-YY/graphene-django
that referenced
this pull request
Jan 18, 2023
ipyramiddev
added a commit
to ipyramiddev/graphene-api-django
that referenced
this pull request
Mar 22, 2023
paxaxel223
added a commit
to paxaxel223/graphe-django
that referenced
this pull request
Apr 25, 2023
igodev0001
pushed a commit
to igodev0001/graphene-django
that referenced
this pull request
Jul 4, 2023
DevStar1016
pushed a commit
to DevStar1016/graphine-django
that referenced
this pull request
Sep 11, 2023
code-worm19
added a commit
to code-worm19/graphene-api-django
that referenced
this pull request
Jan 23, 2025
Yaroslav-Dev007
added a commit
to Yaroslav-Dev007/graphene-django
that referenced
this pull request
Feb 9, 2025
BohdanS000
added a commit
to BohdanS000/python-django-graphql
that referenced
this pull request
Feb 15, 2025
light0725
added a commit
to light0725/graphene-django
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the
[1]
was ommitted from thefrom_global_id
call as that method returns a tuple of type and id, of which we're only interested in the id here. Took me half a day to figure out why this code wasn't working today. See function def here: https://github.com/graphql-python/graphql-relay-py/blob/master/graphql_relay/node/node.py#L67