Skip to content

Replaced a copy-paste error causing one test case not to run #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2019
Merged

Replaced a copy-paste error causing one test case not to run #604

merged 1 commit into from
Mar 30, 2019

Conversation

GitRon
Copy link
Contributor

@GitRon GitRon commented Mar 27, 2019

Two functions were named like an existing function so the test would not run. Fixed this.

mvanlonden
mvanlonden approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@mvanlonden mvanlonden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.356% when pulling d5d0c51 on GitRon:bugfix/copy-paste-error-test-function-names into ea2cd98 on graphql-python:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.356% when pulling d5d0c51 on GitRon:bugfix/copy-paste-error-test-function-names into ea2cd98 on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.356% when pulling d5d0c51 on GitRon:bugfix/copy-paste-error-test-function-names into ea2cd98 on graphql-python:master.

BossGrand
BossGrand approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@BossGrand BossGrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for the fix!

@GitRon
Copy link
Contributor Author

GitRon commented Mar 29, 2019

Who's gonna merge it? :)

@mvanlonden mvanlonden merged commit 1ad0347 into graphql-python:master Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbyte64 zbyte64 zbyte64 approved these changes

@mvanlonden mvanlonden mvanlonden approved these changes

@BossGrand BossGrand BossGrand approved these changes

@danpalmer danpalmer Awaiting requested review from danpalmer

@firaskafri firaskafri Awaiting requested review from firaskafri

@jkimbo jkimbo Awaiting requested review from jkimbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GitRon @coveralls @zbyte64 @mvanlonden @BossGrand