Skip to content

Cookbook plain 2.1.2 compatible #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2019

Conversation

alqinae
Copy link
Contributor

@alqinae alqinae commented Oct 18, 2018

Hello,

I am Khaled Alqenaei from DjangoCon sprint and I made the example compatible with the latest version of Django which is 2.1.2.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.518% when pulling 4359e1f on alqinae:cookbook-plain-2.1-compatible into f76f38e on graphql-python:master.

@coveralls
Copy link

coveralls commented Oct 18, 2018

Coverage Status

Coverage remained the same at 94.518% when pulling 905b424 on alqinae:cookbook-plain-2.1-compatible into f76f38e on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.518% when pulling 4359e1f on alqinae:cookbook-plain-2.1-compatible into f76f38e on graphql-python:master.

Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Thanks ✨

@patrick91
Copy link
Member

@syrusakbary @spockNinja this is ready to be squashed :) it's also @alqinae first contribution!

@jkimbo jkimbo merged commit 6ce59ae into graphql-python:master Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants