Skip to content

Update authorization docs to Graphene 2.0 #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2018

Conversation

ccsv
Copy link
Contributor

@ccsv ccsv commented Aug 29, 2018

  • Re-write some language in "Limiting Field Access"
  • Added code to "Queryset Filtering On Lists" section to handle queries that return nothing
  • fix code to Filtering ID-based node access to work based on question here
  • Rewrote Adding Login Requirements to be Django 2.0 compatible
    Fixed login requirements

*  Re-write some language in "Limiting Field Access"
* Added code to "Queryset Filtering On Lists" section to handle queries that return nothing
* fix code to Filtering ID-based node access to work based on question [here](https://stackoverflow.com/questions/51057784/django-graphene-with-relay-restricting-queries-access-based-on-id/51958088#51958088)
* Rewrote Adding Login Requirements to be Django 2.0 compatible 
Fixed login requirements
@coveralls
Copy link

coveralls commented Aug 29, 2018

Coverage Status

Coverage decreased (-0.08%) to 94.587% when pulling 2ccd483 on ccsv:patch-1 into 9351626 on graphql-python:master.

@japrogramer
Copy link

uhm, seeing as this is limiting the access after it has resolved is there a strategy to limit access not in the resolve but before the query is executed

@ccsv
Copy link
Contributor Author

ccsv commented Aug 30, 2018

@japrogramer feel free to change the text I only change up some of the code because it bothered me that my GraphQL stuff did not work and asking around no one really resolved the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants