Skip to content

Always use HTTPS for CDN files #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Conversation

adamchainz
Copy link
Contributor

There's no point using insecure, deprecated HTTP even if the current page is on HTTP.

There's no point using insecure, deprecated HTTP even if the current page is on HTTP.
@coveralls
Copy link

coveralls commented Aug 17, 2018

Coverage Status

Coverage decreased (-0.01%) to 94.652% when pulling d1aecab on adamchainz:patch-1 into 9351626 on graphql-python:master.

@Amoki
Copy link

Amoki commented Aug 28, 2018

What about going one step further and adding the SHA hash of these js ?

@adamchainz
Copy link
Contributor Author

Forgot that's a thing now. I don't have the time to do it here. But it's not possible for two files as they are templated by version with {{graphiql_version}}

@patrick91 patrick91 requested a review from jkimbo August 29, 2018 10:15
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@danpalmer
Copy link
Collaborator

@adamchainz I reckon it's worth doing for the other files, as it reduces the potential attack surface area.

@adamchainz
Copy link
Contributor Author

@danpalmer you're right

@jkimbo jkimbo merged commit ea2cd98 into graphql-python:master Mar 19, 2019
@adamchainz
Copy link
Contributor Author

Thanks!

@adamchainz adamchainz deleted the patch-1 branch March 19, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants