-
Notifications
You must be signed in to change notification settings - Fork 767
Added tox.ini and improved travis.yml #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a406832
to
fe39fe1
Compare
@sciyoshi Any news ? |
1 similar comment
@sciyoshi Any news ? |
Looks fine to me, but I don't have commit access. Please ask @syrusakbary or @jm2242 to review + merge. |
I'm happy to take a look but I'm not sure I'm involved in the project enough to have a say! |
@ZuluPro Interested to update this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests seem to only fail for Django < 1.10 ; which we don't currently test. We should go ahead and disable those environments.
d2d5c00
to
db40940
Compare
Hello @firaskafri @zbyte64 I updated my PR, removed <Django 1.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR
I'd like to tidy up some of the PRs, so if we still want to work on this let me know or I will close this in 1 week. |
LGTM. @ZuluPro could you please remove 1.10 and 2.0 as these are not supported anymore. Also resolve the conflict. |
Please resolve conflicts |
Updated Travis YML
Note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phalt let's merge this, and fix django master failure in another PR.
I added a tox file to ease test across Python & Django versions.
I also improved the travis file to use the tox configuration.