Skip to content

Test DjangoObjectType custom meta .setdefault() #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2018
Merged

Test DjangoObjectType custom meta .setdefault() #391

merged 1 commit into from
Mar 30, 2018

Conversation

mongkok
Copy link
Contributor

@mongkok mongkok commented Feb 3, 2018

No description provided.

@coveralls
Copy link

coveralls commented Feb 3, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 94.203% when pulling 55dc657 on mongkok:test-custom-meta-setdefault into e827b10 on graphql-python:master.

@spockNinja
Copy link
Contributor

Hello, @mongkok. Thanks for the PR. Could you provide some context, please? I'm not entirely sure what this test change is trying to address.

@mongkok
Copy link
Contributor Author

mongkok commented Feb 4, 2018 •
edited
Loading

Hello @spockNinja,

I recently sent a pr with a test pull/379.
This is a small improvement, does not fix anything, for the next time I will try to review my changes :)

@syrusakbary syrusakbary merged commit d2c1e7c into graphql-python:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mongkok @coveralls @spockNinja @syrusakbary