Skip to content

Fix failing master test #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2017

Conversation

spockNinja
Copy link
Contributor

@spockNinja spockNinja commented Oct 10, 2017

Problem

Master tests started failing in a strange way.

See https://travis-ci.org/graphql-python/graphene-django/jobs/285520455

It is only failing for the Django 1.8 build. It took a while to pinpoint why, as nothing in our repository changed related to the failure.

encode/django-rest-framework@c674687

Is what started the failure. DRF 3.7.0 does not support Django 1.8 anymore.

Solution

For now, I have a conditional pip install override for our 1.8 build. A few other options exist as well.

  • We could follow suit and stop supporting 1.8.
  • We could pin the general requirement in setup.py to be <3.7.0.
  • Maybe something else?

@spockNinja spockNinja force-pushed the fix_master_failing_test branch 3 times, most recently from 6125b96 to b88d66f Compare October 10, 2017 05:06
@graphql-python graphql-python deleted a comment from coveralls Oct 10, 2017
@graphql-python graphql-python deleted a comment from coveralls Oct 10, 2017
@graphql-python graphql-python deleted a comment from coveralls Oct 10, 2017
@graphql-python graphql-python deleted a comment from coveralls Oct 10, 2017
@spockNinja spockNinja force-pushed the fix_master_failing_test branch from b88d66f to 768fca6 Compare October 10, 2017 05:09
@graphql-python graphql-python deleted a comment from coveralls Oct 10, 2017
@coveralls
Copy link

coveralls commented Oct 10, 2017

Coverage Status

Coverage increased (+0.2%) to 92.999% when pulling 768fca6 on spockNinja:fix_master_failing_test into 77f0361 on graphql-python:master.

@spockNinja
Copy link
Contributor Author

@syrusakbary

I think I've taken the most reasonable and open approach to this strange test failure. It isn't pretty, but it allows us to maintain 1.8 support and also continue to test against the latest drf.

@syrusakbary
Copy link
Member

Looks good @spockNinja!
Merging :)

@syrusakbary syrusakbary merged commit 283bccf into graphql-python:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants