Fix failing master test #287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Master tests started failing in a strange way.
See https://travis-ci.org/graphql-python/graphene-django/jobs/285520455
It is only failing for the Django 1.8 build. It took a while to pinpoint why, as nothing in our repository changed related to the failure.
encode/django-rest-framework@c674687
Is what started the failure. DRF 3.7.0 does not support Django 1.8 anymore.
Solution
For now, I have a conditional pip install override for our 1.8 build. A few other options exist as well.