Skip to content

Remove support to django 1.6 and 1.7 #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2017

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented Jun 23, 2017

Closes #187 and it is helpful for #186 :)

@coveralls
Copy link

coveralls commented Jun 23, 2017

Coverage Status

Coverage decreased (-3.04%) to 90.76% when pulling 575e1da on patrick91:feature/up-django into afec960 on graphql-python:master.

@patrick91 patrick91 force-pushed the feature/up-django branch from c32dd19 to 245ebe3 Compare June 23, 2017 11:32
@coveralls
Copy link

coveralls commented Jun 23, 2017

Coverage Status

Coverage decreased (-2.4%) to 91.398% when pulling 245ebe3 on patrick91:feature/up-django into afec960 on graphql-python:master.

@patrick91 patrick91 force-pushed the feature/up-django branch from df7cea0 to 82055ac Compare June 23, 2017 12:05
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 92.102% when pulling 82055ac on patrick91:feature/up-django into afec960 on graphql-python:master.

@coveralls
Copy link

coveralls commented Jun 23, 2017

Coverage Status

Coverage decreased (-1.09%) to 92.71% when pulling 82055ac on patrick91:feature/up-django into afec960 on graphql-python:master.

@patrick91 patrick91 changed the title [WIP] Remove support to django 1.6 and 1.7 Remove support to django 1.6 and 1.7 Jun 23, 2017
@patrick91
Copy link
Member Author

patrick91 commented Jun 23, 2017

@syrusakbary can you have a look at this one as well? :)

Not sure why the coverage has decreased.

@syrusakbary
Copy link
Member

I've analyzed the downloads for Django 1.6, 1.7 vs the newest ones in Google BigQuery database for PyPI:

SELECT
  MONTH(timestamp) as month,
  file.version,
  COUNT(*) as total_downloads
FROM
  TABLE_DATE_RANGE(
    [the-psf:pypi.downloads],
    TIMESTAMP("20170401"),
    CURRENT_TIMESTAMP()
  )
WHERE
  file.project = 'django'
GROUP BY
 month,
 file.version
ORDER BY
file.version,
month
LIMIT 1000

And the downloads for Django 1.6, Django 1.7 are now considerably low for the latest month compared to the most recent versions.

I think is reasonable to deprecate support for it (will add a small note in the README)

Merging :)

@syrusakbary syrusakbary merged commit 7eb4106 into graphql-python:master Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants