Skip to content

Fix graphene 1.3 annotation bug #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2017
Merged

Fix graphene 1.3 annotation bug #194

merged 1 commit into from
Jun 29, 2017
+60 −1

Conversation

dvdmgl
Copy link
Contributor

@dvdmgl dvdmgl commented Jun 5, 2017 •
edited
Loading

Fixes #173

@coveralls
Copy link

coveralls commented Jun 5, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-3.04%) to 90.76% when pulling 19286e4 on dvdmgl:173-annotation-bug into afec960 on graphql-python:master.

@dvdmgl dvdmgl force-pushed the 173-annotation-bug branch from 19286e4 to b3c761b Compare June 6, 2017 18:19
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.04%) to 90.76% when pulling b3c761b on dvdmgl:173-annotation-bug into afec960 on graphql-python:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.04%) to 90.76% when pulling b3c761b on dvdmgl:173-annotation-bug into afec960 on graphql-python:master.

@coveralls
Copy link

coveralls commented Jun 6, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-3.04%) to 90.76% when pulling b3c761b on dvdmgl:173-annotation-bug into afec960 on graphql-python:master.

@syrusakbary syrusakbary merged commit 7263485 into graphql-python:master Jun 29, 2017
@crucialfelix
Copy link

Thanks for the fix. What is in default_query_set that it should always be merged with the query_set that we supply ? It seems to me that I supply a query_set then it should be used as is. Merging with default_query_set seems dangerous.

@jole78
Copy link

jole78 commented Aug 17, 2017

is this fix released on PyPI??

@crucialfelix
Copy link

I don't think so

@jancespivo jancespivo mentioned this pull request Sep 14, 2017
Closed
@dvdmgl dvdmgl deleted the 173-annotation-bug branch September 15, 2017 00:28
@spockNinja spockNinja mentioned this pull request Sep 30, 2017
Merged
@spockNinja spockNinja mentioned this pull request Oct 14, 2017
Merged
@dleitee
Copy link

dleitee commented Oct 18, 2017

Why is it not o PyPi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dvdmgl @coveralls @crucialfelix @jole78 @dleitee @syrusakbary