fix select_related and prefetch_related set in resolver getting lost #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 similar comments
jsurloppe
force-pushed
the
fix-related-filter
branch
from
ebc872c to
0cabdb3
Compare
1 similar comment
jsurloppe
force-pushed
the
fix-related-filter
branch
from
0cabdb3 to
5536fc9
Compare
|
Hey @jsurloppe, could you add some tests that showcases the issue so we assure that there is no regression in the future? |
|
I think this might be causing the bug in #173 |
syrusakbary
force-pushed
the
master
branch
2 times, most recently
from
bdc7189 to
f93251b
Compare
|
Closing this PR in favor of #315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite prefetching relation in resolve_ method, the relations are lost and filter redo n+1 queries.
This patch may introduce a reverse bug where relations prefetched in the default_queryset are lost, i haven't tested but i think this is way less problematic.