-
Notifications
You must be signed in to change notification settings - Fork 765
adding optional_field in Serializermutation to enfore some fields to be optional #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this was available in v2 however i found it removed in v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mahmoudmostafa0. There's a small typo there. Also could you run the linting as well (tox -e pre-commit
)?
Co-authored-by: Kien Dang <kiend@pm.me>
# Conflicts: # graphene_django/rest_framework/mutation.py
thanks @kiendang for reviewing I`ve tried out the linting and this is the final results I got : check for merge conflicts................................................Passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Need another set of eyes though.
This is the same as #1080 which was merged into v2.
i want to use rest_framework Serializermutation and i want to force some fields to be optional