Bug with Django ChoiceField

[valdergallo]

Hi, hi
I got one bug using models.CharField with choices.
Graphene is creating two differents objects as Enum.
Raising one error in graphene.types.typemap

File "/usr/local/lib/python2.7/dist-packages/graphene-1.1.3-py2.7.egg/graphene/types/typemap.py", line 64, in reducer
    return self.graphene_reducer(map, type)
  File "/usr/local/lib/python2.7/dist-packages/graphene-1.1.3-py2.7.egg/graphene/types/typemap.py", line 82, in graphene_reducer
    return self.construct_objecttype(map, type)
  File "/usr/local/lib/python2.7/dist-packages/graphene-1.1.3-py2.7.egg/graphene/types/typemap.py", line 153, in construct_objecttype
    map[type._meta.name]._fields = self.construct_fields_for_type(map, type)
  File "/usr/local/lib/python2.7/dist-packages/graphene-1.1.3-py2.7.egg/graphene/types/typemap.py", line 214, in construct_fields_for_type
    map = self.reducer(map, field.type)
  File "/usr/local/lib/python2.7/dist-packages/graphene-1.1.3-py2.7.egg/graphene/types/typemap.py", line 64, in reducer
    return self.graphene_reducer(map, type)
  File "/usr/local/lib/python2.7/dist-packages/graphene-1.1.3-py2.7.egg/graphene/types/typemap.py", line 82, in graphene_reducer
    return self.construct_objecttype(map, type)
  File "/usr/local/lib/python2.7/dist-packages/graphene-1.1.3-py2.7.egg/graphene/types/typemap.py", line 153, in construct_objecttype
    map[type._meta.name]._fields = self.construct_fields_for_type(map, type)
  File "/usr/local/lib/python2.7/dist-packages/graphene-1.1.3-py2.7.egg/graphene/types/typemap.py", line 214, in construct_fields_for_type
    map = self.reducer(map, field.type)
  File "/usr/local/lib/python2.7/dist-packages/graphene-1.1.3-py2.7.egg/graphene/types/typemap.py", line 64, in reducer
    return self.graphene_reducer(map, type)
  File "/usr/local/lib/python2.7/dist-packages/graphene-1.1.3-py2.7.egg/graphene/types/typemap.py", line 69, in graphene_reducer
    return self.reducer(map, type.of_type)
  File "/usr/local/lib/python2.7/dist-packages/graphene-1.1.3-py2.7.egg/graphene/types/typemap.py", line 64, in reducer
    return self.graphene_reducer(map, type)
  File "/usr/local/lib/python2.7/dist-packages/graphene-1.1.3-py2.7.egg/graphene/types/typemap.py", line 79, in graphene_reducer
    assert _type.graphene_type == type
AssertionError
********************************************************************************
_type.graphene_type  UserMobile1Os 139869850885568
type UserMobile1Os 139869850674512
********************************************************************************

My model

MOBILE_PLATFORMS_CHOICES = (
    ('android', 'Android'),
    ('ios', 'iOS'),
)


class User(AbstractUser):
    full_name = models.CharField(max_length=64, blank=True)
    mobile_1_os = models.CharField(max_length=10, default='android',
                                   choices=MOBILE_PLATFORMS_CHOICES,
                                   db_index=True)

My query

class Query(graphene.AbstractType):
    users = DjangoConnectionField(
        UserNode
    )

My UserNode

class UserNode(DjangoObjectType):
    class Meta(object):
        interfaces = (relay.Node,)
        model = User

And I have one file for Schemas

class AllQuery(Query, ObjectType):

   viewer = graphene.Field(lambda: AllQuery)

    @classmethod
    def resolve_viewer(cls, *args, **kwargs):
        return AllQuery()

schema_graphene = graphene.Schema(query=AllQuery)

[valdergallo]

This big number (139869850885568 and 139869850674512) is id(_type.graphene_type) and id(type)

[steineron]

Having the exact same issue with 1.10.5x1.1.3x1.2.1 at graphene/types/typemap.py in graphene_reducer, line 73: the expression _type.graphene_type == type evaluates to False.

Using a debugger I could see how id(_type.graphene_type) is different that id(type) for the enums created out of "choices". id(..) on all other types compare.

[kozickikarol]

Same problem on graphene 1.2.0

[aaxelb]

I ran into this problem with a proxy model, something like:

class BaseModel(models.Model):
      choice_field = models.IntegerField(choices=((0, 'zero'), (1, 'one')))
 
class ChildModel(BaseModel):
      class Meta:
          proxy = True

and submitted #156 to fix it.

[adamdonahue]

A major flaw in thinking here is the implication that choices are enums at all. They have specific values.

[jsep]

I have the same issue but I found workaround.

1. Exclude the choices property
2. Create an Enum for the choices
3. In the node, create a property with the same name as the choice property and use graphene.Enum
4. Create a resolver for the property in the node

See example below. Hope this helps.

class ModelWithChoices(models.Model):
    name = models.CharField(max_length=10)
    choices_property = models.CharField(max_length=20, null=True, blank=True,
                                         choices=(("choice_one", "choice"),
                                                        ("other_choice", "other choice"),) )


class ChoicesPropertyEnum(graphene.Enum):
    CHOICE_ONE = "choice"
    OTHER_ONE = "other choice"


class ModelWithChoicesNode(DjangoObjectType):

    choices_property = ChoicesPropertyEnum()

    class Meta:
        model = ModelWithChoices
        interfaces = [relay.Node]
        exclude_fields = ['choices_property']

    def resolve_choices_property(self, info, **kwargs):
        return self.choices_property

[neural22]

thanks @jsep it works also for me

[mohamedrez]

another way that I tried and it worked:

    choices_property = graphene.String()

    def resolve_choices_property(self, info, **kwargs):
        return self.get_choices_property_display()

No need to excucled the field