Django integer fields gets transformed to Float?

[crazyscientist]

On a project of mine I noticed this unexpected behavior:

Using graphene_django with graphene.relay converts IntegrierFields of my models to graphene.Float properties in the API, e.g.:

class Incident(models.Model):
    incident_id = models.IntegerField(unique=True)

class IncidentType(graphene_django.types.DjangoObjectType):
    class Meta:
        model = Incident
        interfaces = (graphene.relay.Node,)
        filter_fields = {
            'incident_id': ['exact'],
    }

class Query:
    incident = graphene.relay.Node.Field(IncidentType)
    incidents = DjangoFilterConnectionField(IncidentType)

To be precise, using the incident attribute shows the incidentId to be of type Int. But using the incidents attribute suggests that incidentId is of type Float.

I'd like to point out, that there is no error occurring, but it strikes me as weird.

I observed this with:

• Django 2.2
• django-filter 2.1.0
• graphene 2.1.3
• graphene-django 2.2.0
• graphql-core 2.1
• graphql-relay 0.4.5

[jkimbo]

@crazyscientist I can't reproduce your issue. If I setup my schema in the following way:

from django.db import models

import graphene

from graphene_django.types import DjangoObjectType
from graphene_django.filter import DjangoFilterConnectionField


class Incident(models.Model):
    incident_id = models.IntegerField(unique=True)


class IncidentType(DjangoObjectType):
    class Meta:
        model = Incident
        interfaces = (graphene.relay.Node,)
        filter_fields = {"incident_id": ["exact"]}


class Query(graphene.ObjectType):
    incident = graphene.relay.Node.Field(IncidentType)
    incidents = DjangoFilterConnectionField(IncidentType)

schema = graphene.Schema(query=Query)
print(str(schema))

I get the following schema:

schema {
  query: Query
}

type IncidentType implements Node {
  id: ID!
  incidentId: Int!
}

type IncidentTypeConnection {
  pageInfo: PageInfo!
  edges: [IncidentTypeEdge]!
}

type IncidentTypeEdge {
  node: IncidentType
  cursor: String!
}

interface Node {
  id: ID!
}

type PageInfo {
  hasNextPage: Boolean!
  hasPreviousPage: Boolean!
  startCursor: String
  endCursor: String
}

type Query {
  incident(id: ID!): IncidentType
  incidents(before: String, after: String, first: Int, last: Int, incidentId: Float): IncidentTypeConnection
}

Where IncidentType has the field incidentId of type Int which is what I would expect.

The only difference I can see with your code is that you should make sure that Query inherits from graphene.ObjectType (it doesn't in your example).

Can you make a small reproducible example of the issue you are seeing?

[crazyscientist]

@jkimbo thanks for the reply, but you actually reproduced it:

# as expected an Int
type IncidentType implements Node {
  id: ID!
  incidentId: Int!
}

# here incidentId has become a Float?!
type Query {
  incident(id: ID!): IncidentType
  incidents(
    before: String, 
    after: String, 
    first: Int, last: Int, 
    incidentId: Float 
  ): IncidentTypeConnection
}

Don't get me wrong, the API is working as expected. I was just suprised that the type is Float

[jkimbo]

Huh I didn't notice that! Very strange, I'll look into why that's happening.

[jkimbo]

Ok so I've figured out what is going on but I'm not sure how to fix it. Basically Django-filter converts an IntegerField into a NumberFilter and a NumberFilter defines it's Django form field as a DecimalField. Graphene-Django uses that form field to determine the GraphQL type to use for the filter:

graphene-django/graphene_django/forms/converter.py

Lines 54 to 57 in 612ba5a

	@convert_form_field.register(forms.DecimalField)
	@convert_form_field.register(forms.FloatField)
	def convert_form_field_to_float(field):
	return Float(description=field.help_text, required=field.required)

I'm trying to figure out a way for the argument conversion to look at the actual underlying model field rather than the filter field but it's proving to be tricky. The relevant code is here:

graphene-django/graphene_django/filter/utils.py

Line 6 in 612ba5a

def get_filtering_args_from_filterset(filterset_class, type):

[crazyscientist]

Thanks for the investigation @jkimbo .

To me this sounds more like an issue for Django-filter 🤔

[jkimbo]

Possibly though from their perspective the NumberField makes sense, it's just that Graphene needs more accurate type information. I think I have a fix that could work, just doing some testing on it now.

[jkimbo]

@crazyscientist I've created a PR that should fix the issue: #682

[Gamsake]

I have the exact same issue on 2.4.0 the latest.
May i ask that you will apply the fix in v3?
Thanks.

[jkimbo]

@Gamsake this issue should be fixed in v2.4.0. Can you create a reproduction of the issue you are having?

[Gamsake]

@jkimbo Yes. I'm using 2.4.0 the latest now and 'id' the field of my model has Int type, but it is converted into Float type. Exactly same issue as above first post. I've done triple checks but i never solve this problem. any clue plz.