Filtering fields ignored inside fragments

[felix-weizman-deel]

Hello guys,

I'm trying to run this query and it's completely ignore the 'employeeType'(or any other) filter:

{
 business(id: "") {
    ...F2
  }
}

fragment F2 on BusinessNode {
  employee(employeeType:":ceo") {
    edges {
      node {
        status
        employeeType
        id
      }
    }
  }
}

On the second hand, this query works perfectly fine:

employee(employeeType:":ceo") {
    edges {
     node {
       status
       employeeType
       id
      }
    }
  }

Both of the objects(BusinessNode and EmployeeNode) are DjangoObjectType.

Thanks,
Felix

[kozickikarol]

Same problem +1

Edit:
Sorting nodes inside fragments also does not work.

[syrusakbary]

That's a weird issue. Maybe is a bug in graphql-core or graphene itself.

Could you post a fully working example that replicates the issue? (a gist or a PR with a failing test would also work :) )

[felix-weizman-deel]

I'm using the cookbook example, and it's works perfectly fine(return only one row):

 {
  allIngredients(notes: "Comes from a cow") {
    edges {
      node {
        id
        notes
        name
      }
    }
  }
}

but when i use fragment, its return two rows:

{
  allCategories(name: "Dairy") {
    edges {
      node {
        ...F2
      }
    }
  }
}

fragment F2 on CategoryNode {
  ingredients(notes: "Comes from a cow") {
    edges {
      node {
        id
        notes
        name
      }
    }
  }
}

[BossGrand]

It doesn't even need to be a fragment for this to happen. If you run this query on the cookbook example graphiql page you can see the bug. The filter on name is completely ignored

query{
  allCategories {
    edges {
       node {
           id,
           ingredients(name_Icontains:"beef") {
              edges {
                 node {
                    id,
                    name
                 }
              }
           }
        }
     }
  }
}

[tom-zeit]

This issue prevents us from upgrading to graphene 1.0 :/
Anyway has a lead on how to solve it?

[timothyjlaurent]

I'm just noticing this too after writing tests for our app migration... This is a real problem... Need to be able to to filter on nested nodes.

            query ($docid: String!, $label: String!) {
                allGene(docid_In: $docid) {  <-- this filter works
                    edges {
                        node {
                            id
                            docid
                            geneReportText (label: $label) { <-- this filter doesn't do anything
                                edges {
                                    node {
                                        text
                                        label
                                        status
                                    }
                                }
                            }
                        }
                    }
                }
            }

Please point me to where I can fix it @syrusakbary

[timothyjlaurent]

This was solved in #30 by @drakon

If you would like to try it

pip install this:

-e git://github.com/timothyjlaurent/graphene-django.git@94ab3d6d593eb514fad97132870fc99bbdca245d#egg=graphene-django

[pchinea]

I found anther solution calculating intersection between the resolved relationship and the filtered manager, and this passed the tests.

Please check my PR #82 to verify this works in all cases.

[syrusakbary]

This should be fixed with #82. Closing the issue