Added statistics support #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction and batch invoke count the number of invocations of the batch function
andimarek
approved these changes
Sep 20, 2017
| /** | ||
| * A simple set of statistics about {@link org.dataloader.DataLoader} operations | ||
| */ | ||
| public interface Statistics { |
There was a problem hiding this comment.
Not sure an interface is really needed here.
| /** | ||
| * This allows statistics to be collected for {@link org.dataloader.DataLoader} operations | ||
| */ | ||
| public interface StatisticsCollector { |
There was a problem hiding this comment.
not sure if it is really needed to always return then current value after the "action": the class itself itself is designed to be stateful and you can always call getStatistics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10 - added statistics to dataloader
Want to eventually incorporate this into graphql-java so we can capture per call stats