Skip to content

Implemented check for EnumValues in schema #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Implemented check for EnumValues in schema #1532

wants to merge 1 commit into from

Conversation

ieugen
Copy link

@ieugen ieugen commented May 10, 2019

bbakerman
bbakerman requested changes May 14, 2019
View reviewed changes
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

If you could please add some tests to show this working...otherwise we are likely to regress at some stage.

@bbakerman bbakerman added this to the 13.0 milestone May 14, 2019
@ieugen
Copy link
Author

ieugen commented May 14, 2019

I made an effort and wrote the tests as I would really love to see a bugfix release for 12.0 branch. Any plans of this happening? Right now we have an internal build but it would be great to drop that and use the upstream version.

Thanks,

@bbakerman
Copy link
Member

I would really love to see a bugfix release for 12.0 branch. Any plans of this happening?

Sorry - our bug fix branch is 9.x - we don't have the capacity to maintain bugs branches per releases

@bbakerman bbakerman mentioned this pull request May 20, 2019
Closed
@ieugen ieugen mentioned this pull request May 21, 2019
Closed
@ieugen
Copy link
Author

ieugen commented May 21, 2019 •
edited
Loading

Sorry - our bug fix branch is 9.x - we don't have the capacity to maintain bugs branches per releases

I understand. Can I help with the maintenance?

@bbakerman bbakerman removed this from the 13.0 milestone Jun 11, 2019
@bbakerman
Copy link
Member

For the same reasons outlined here #1533

On reflection we are reluctant to accept this PR since its fixing a behavior of an upstream library that should not be passing AST values into enums and scalars

@bbakerman bbakerman closed this Sep 9, 2019
@ieugen ieugen deleted the v12-enum-coercing-patch branch September 9, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbakerman bbakerman bbakerman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enum Values are not recognized
2 participants
@ieugen @bbakerman