Skip to content

make directives repeatable by default #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nagliyvred
Copy link

Fixes #615

Checklist

  • Pull requests follows the contribution guide
  • New or modified functionality is covered by tests

Description

Currently directive definitions are being ignored when parsing the schema and all directives are being assumed non-repeated. This is causing issues, for example, when using apollo-federation, as it prevents duplicate @key annotations on the federated entity.
While this PR doesn't fix the problem in it's entirety (for example, by parsing directives properly and validating them, as mentioned in #225 ) - it at least allows directive information not to get lost, by assuming all directives could be repeated.

@oryan-block
Copy link
Collaborator

Can you check if #645 solves your problem? There was an overwhole of the directives code in GraphQL Java 18

@nagliyvred
Copy link
Author

Thanks, will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated directives are ignored
2 participants