Revert "Add the TrivialDataFetcher interface to MethodFieldResolver so that i…" #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliemansm
commented
Nov 16, 2019
| && this.method.parameterCount == 0 | ||
| && this.method.name.startsWith("get") | ||
| && this.search.type is java.lang.Class<*> | ||
| && (this.search.type as java.lang.Class<*>).getMethod(this.method.getName()) != null |
There was a problem hiding this comment.
@cliedeman This line throws a NoSuchMethodException for methods with package private scope therefore breaking backwards compatibility. Can you add unit tests to ensure it's working properly including the package private use case? Once all that's working I can merge it again.
|
I created a new PR #337, I realised I don't need to check the type class because the method object was already obtained earlier via the method resolvers. Are you happy with this approach? |
oliemansm
added a commit
that referenced
this pull request
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #330