Not working in module mode

[kortschak]

I am trying to run github.com/kortschak/graphprac on my local machine. I always run with module mode on, Go version 1.13.

When I try to run the first cell of the notebook at that repo I get a failure that the build with buildmode=plugin failed. When I execute this in a terminal to investigate I see that it's because the go tool expects the go.mod file to exist and bails otherwise. Creating a go mod file in that directory allows the build to complete and also allows the cell to execute on the notebook.

Perhaps the go.mod from imported packages' modules could be placed in the gomacro build paths.

At the very least, it should be noted that it might be necessary to invoke the server with GO111MODULE=off jupyter notebook.

[kortschak]

Note that gomacro as of cosmos72/gomacro@24fc920 executes the code that fails here without issue.

[mattn]

OT: gophernotes dropped support of Go 1.10. So we can remove vendor.

[cosmos72]

https://github.com/cosmos72/gomacro has a go.mod and is thus compiled with modules support,
but its runtime is not yet module aware - thus evaluating import will not find modules in $GOPATH/pkg/mod.

I am working to fix that.

[cosmos72]

I added modules support to gomacro - i.e. import is now module aware.
ASAP I will update also gophernotes to use the latest gomacro.

[cosmos72]

Working on it, see #189
Also see #187 for a very similar issue

[cosmos72]

It should work now, waiting for @kortschak confirmation before closing

[mattn]

Question, when importing different version of module which is already used in gophernotes's dependencies, what you expect?

error loading plugin "/home/mattn/go/src/gomacro.imports/gonum.org/v1/plot/plot.so": plugin.Open("/home/mattn/go/src/gomacro.imports/gonum.org/v1/plot/plot.so"): plugin was built with a different version of package golang.org/x/image/math/fixed (previous failure)

[cosmos72]

I expect exactly the error you report, because plugin allows loading the same package multiple times only if they have exactly the same version.

I already thought about this problem in the past, and there are two complementary solutions:

1. If gophernotes depends on a package foo, generate an import file for it in the 'imports' directory
2. When compiling a plugin to load the symbols of a package bar, also cache the symbols of all its dependencies - a later import of one of the dependencies will be satisfied from the cache, without loading another plugin (which may have a different version, as you point out).

These are future improvements for gophernotes (1) and gomacro (2)

[kortschak]

This is fixed for me as noted in the PR.

[mattn]

If I want to use packages in the document and the packages are used in gophernotes, I should set GO111MODULE=off ?

[cosmos72]

Environment GO111MODULE is now ignored by gophernotes at runtime: internally, it always sets it to on before importing a package.
The underlying Gomacro has a user-controlled option to toggle GO111MODULE on/off but gophernotes has no mechanism to invoke it (yet).

Anyway there should be very few packages used in gophernotes without a corresponding import file in 'imports' directory:
at first glance, I'd say only github.com/pebbe/zmq4 and github.com/satori/go.uuid.
Their transitive dependencies are all in the standard library, and that's not an issue.

Maybe I am missing something?

[mattn]

I could solve issue that can't import packages which is used in gophernotes.

One another issue is that can't import packages in different versions. I'm trying to use my package https://github.com/mattn/go-pairplot and this import golang.org/x/image but gonum.org/v1/plot/vg also import golnang.org/x/image/font/fixed.

[mattn]

Hmm, importing "github.com/mattn/go-runewidth" fail.