Use bufio.Reader to handle large git histories #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Processing large git repositories with `revgrep` may result in failed parsing due to long lines. For example: ``` $ golint ./... |& revgrep abcd1234 reading standard input: bufio.Scanner: token too long ``` From the Go documentation for Scanner: ``` Programs that need more control over error handling or large tokens, or must run sequential scans on a reader, should use bufio.Reader instead. ``` This updates `revgrep`'s git reader to use `bufio.Reader` to avoid this issue. For example: ``` $ golint ./... |& revgrep abcd1234 mycode.go:8:2: a blank import should be only in a main or test package, or have a comment justifying it ```
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing large git repositories with
revgrepmay result in failedparsing due to long lines. For example:
From the Go documentation for Scanner:
This updates
revgrep's git reader to usebufio.Readerto avoid thisissue. For example:
I don't have a reproducible test case as this happened in non-public code,
but can try to put one together.
The tests are failing for me on
TestChangesWriterfor this PR, but the sameoccur encountered on
master.