Skip to content

go1.25 support #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
GO_VERSION: '1.24'
GO_VERSION: '1.25.0-rc.1'
NODE_VERSION: '20.x'
CGO_ENABLED: 0
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/post-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ env:
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
GO_VERSION: '1.24'
GO_VERSION: '1.25.0-rc.1'

jobs:
update-gha-assets:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ env:
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
GO_VERSION: '1.24'
GO_VERSION: '1.25.0-rc.1'

jobs:
# Check if there is any dirty change for go mod tidy
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
GO_VERSION: '1.24'
GO_VERSION: '1.25.0-rc.1'
NODE_VERSION: '20.x'
CGO_ENABLED: 0

Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/pr-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ env:
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
GO_VERSION: '1.24'
GO_VERSION: '1.25.0-rc.1'

jobs:
# Check if there is any dirty change for go mod tidy
Expand Down Expand Up @@ -39,7 +39,9 @@ jobs:
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
go-version: ${{ env.GO_VERSION }}
# TODO(ldez) must be changed after the first release of golangci-lint with go1.24
# go-version: ${{ env.GO_VERSION }}
go-version: '1.24'
- name: lint
uses: golangci/golangci-lint-action@v8.0.0
with:
Expand Down Expand Up @@ -75,8 +77,8 @@ jobs:
- ubuntu-latest
- ubuntu-24.04-arm
golang:
- '1.23'
- '1.24'
- '1.25.0-rc.1'
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
GO_VERSION: '1.24'
GO_VERSION: '1.25.0-rc.1'
CHOCOLATEY_VERSION: 2.2.0
steps:
# temporary workaround for an error in free disk space action
Expand Down
2 changes: 1 addition & 1 deletion build/buildx-alpine.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# syntax=docker/dockerfile:1.4
FROM golang:1.24-alpine
FROM golang:1.25-alpine

# related to https://github.com/golangci/golangci-lint/issues/3107
ENV GOROOT /usr/local/go
Expand Down
2 changes: 1 addition & 1 deletion build/buildx.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# syntax=docker/dockerfile:1.4
FROM golang:1.24
FROM golang:1.25

# related to https://github.com/golangci/golangci-lint/issues/3107
ENV GOROOT /usr/local/go
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/golangci/golangci-lint/v2

go 1.23.0
go 1.24.0

require (
4d63.com/gocheckcompilerdirectives v1.3.0
Expand Down
4 changes: 1 addition & 3 deletions pkg/commands/internal/migrate/versionone/output.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ type OutputFormat struct {
type OutputFormats []OutputFormat

func (p *OutputFormats) UnmarshalText(text []byte) error {
formats := strings.Split(string(text), ",")

for _, item := range formats {
for item := range strings.SplitSeq(string(text), ",") {
format, path, _ := strings.Cut(item, ":")

*p = append(*p, OutputFormat{
Expand Down
Loading
Loading