Specify go and toolchain versions separately

[AlekSi]

That makes it easier to consume via 1.24's go tool.

[alexandear]

Could you please provide a more detailed description of the problem? It is currently difficult to understand the issue that this PR is intended to address.

[AlekSi]

Ok, actually, there is no problem (or at least I can't reproduce it anymore after switching to 1.24).
But I think it is just weird to require the 1.23.0 language version (that's what the go directive means now) and not just 1.23.
The somewhat related fix was done in #5112.

[ldez]

The min Go version can be a release version or the family version, the Go documentation is not clear but this is perfectly right:

• https://go.dev/ref/mod#go-mod-file-go
• https://go.dev/doc/toolchain#version

So we don't need to have an explicit toolchain version.

Thank you anyway.

[AlekSi]

I know that it can be. But I think it shouldn't be in that case: there is nothing about 1.24.0 specifically that golangci-lint requires. For example, you would want to use 1.24.1 once it is released. Then, you would update go directive to use 1.24.1 without adding toolchain directive. In turn, that would force all users of golangci-lint that specify it in the tool directive to update to 1.24.1 – and there is no reason for that if they are not affected by 1.24.0 bugs.

[ldez]

In fact, we don't update the min Go version with a patched version for the same reasons we are using min go 1.23 instead of go 1.24.

go install, go tool, and tools pattern are strongly discouraged ways to install golangci-lint but if some users use them, golangci-lint should not force the update of the Go version.
This is also a problem with OS distributions that are slow to update the Go versions.

https://golangci-lint.run/welcome/install/#install-from-sources

there is nothing about 1.24.0 specifically that golangci-lint requires.

This is not exactly right: golangci-lint can be compiled with go1.23 but in this case, it will not work with go1.24.