Skip to content

dev: improve formatting and description in flagsets #4636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

aimuz
Copy link
Contributor

@aimuz aimuz commented Apr 11, 2024

--- 1.txt       2024-04-11 22:35:51
+++ 2.txt       2024-04-11 22:36:24
@@ -11,7 +11,8 @@
   -E, --enable strings                 Enable specific linter
       --enable-all                     Enable all linters
       --fast                           Enable only fast linters from enabled linters set (first run won't be fast)
-  -p, --presets strings                Enable presets (bugs|comment|complexity|error|format|import|metalinter|module|performance|sql|style|test|unused) of linters. Run 'golangci-lint help linters' to see them. This option implies option --disable-all
+  -p, --presets strings                Enable presets (bugs|comment|complexity|error|format|import|metalinter|module|performance|sql|style|test|unused) of linters.
+                                       Run 'golangci-lint help linters' to see them. This option implies option --disable-all
       --enable-only strings            Override linters configuration section to only run the specific linter(s)
   -j, --concurrency int                Number of CPUs to use (Default: number of logical CPUs) (default 12)
       --modules-download-mode string   Modules download mode. If not empty, passed as -mod=<mode> to go tools
@@ -20,8 +21,10 @@
       --build-tags strings             Build tags
       --timeout duration               Timeout for total work (default 1m0s)
       --tests                          Analyze tests (*_test.go) (default true)
-      --allow-parallel-runners         Allow multiple parallel golangci-lint instances running. If false (default) - golangci-lint acquires file lock on start.
-      --allow-serial-runners           Allow multiple golangci-lint instances running, but serialize them around a lock. If false (default) - golangci-lint exits with an error if it fails to acquire file lock on start.
+      --allow-parallel-runners         Allow multiple parallel golangci-lint instances running.
+                                       If false (default) - golangci-lint acquires file lock on start.
+      --allow-serial-runners           Allow multiple golangci-lint instances running, but serialize them around a lock.
+                                       If false (default) - golangci-lint exits with an error if it fails to acquire file lock on start.
       --out-format string              Formats of output: json|line-number|colored-line-number|tab|colored-tab|checkstyle|code-climate|html|junit-xml|github-actions|teamcity (default "colored-line-number")
       --print-issued-lines             Print lines of code with issue (default true)
       --print-linter-name              Print linter name in issue line (default true)

Added line breaks to make it more readable than before

Signed-off-by: aimuz <mr.imuz@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Apr 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

boring-cyborg bot commented Apr 11, 2024

Hey, thank you for opening your first Pull Request !

@ldez ldez self-requested a review April 11, 2024 14:52
@ldez ldez added the blocked Need's direct action from maintainer label Apr 11, 2024
@ldez ldez changed the title fix: Improve formatting and description clarity in flagsets.go dev: improve formatting and description clarity in flagsets.go Apr 11, 2024
@ldez ldez changed the title dev: improve formatting and description clarity in flagsets.go dev: improve formatting and description in flagsets Apr 11, 2024
@ldez ldez added topic: cosmetic changes contain cosmetic improvements area: CLI Related to CLI labels Apr 11, 2024
@ldez ldez removed the blocked Need's direct action from maintainer label Apr 11, 2024
@ldez ldez added this to the next milestone Apr 11, 2024
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 5cefda5 into golangci:master Apr 11, 2024
@ldez ldez modified the milestones: next, v1.58 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CLI Related to CLI topic: cosmetic changes contain cosmetic improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants