Skip to content

plugin: temporarily hide warning about using plugins using the old API #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2023
Merged

plugin: temporarily hide warning about using plugins using the old API #4002

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
105da96
chore: hide warning
ldez Aug 11, 2023
e825078
Update pkg/lint/lintersdb/custom_linters.go
ldez Aug 11, 2023
06af7c4
chore: improve todo
ldez Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/lint/lintersdb/custom_linters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package lintersdb

import (
"fmt"
"os"
"path/filepath"
"plugin"

Expand Down Expand Up @@ -115,8 +116,11 @@ func (m *Manager) lookupAnalyzerPlugin(plug *plugin.Plugin) ([]*analysis.Analyze
return nil, err
}

m.log.Warnf("plugin: 'AnalyzerPlugin' plugins are deprecated, please use the new plugin signature: " +
"https://golangci-lint.run/contributing/new-linters/#create-a-plugin")
// TODO(ldez): remove this env var (but keep the log) in the next minor version (v1.55.0)
if _, ok := os.LookupEnv("GOLANGCI_LINT_HIDE_WARNING_ABOUT_PLUGIN_API_DEPRECATION"); !ok {
m.log.Warnf("plugin: 'AnalyzerPlugin' plugins are deprecated, please use the new plugin signature: " +
"https://golangci-lint.run/contributing/new-linters/#create-a-plugin")
}

analyzerPlugin, ok := symbol.(AnalyzerPlugin)
if !ok {
Expand Down