Skip to content

docs: remove description for deprecated "go" option #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented Mar 10, 2023

The default value for go and lang-version options are always overridden by the global run.go:.

@ldez
Copy link
Member

ldez commented Mar 10, 2023

This option is deprecated (see the comment) and the default value is always overridden by the global run.go:.

So the default value of this option doesn't seem useful.

I think that a better default should be an empty value or just the remove of the doc about this option.

@ldez ldez self-requested a review March 10, 2023 08:48
@alexandear alexandear force-pushed the docs-reference-go117 branch from 690200e to 51f9218 Compare March 10, 2023 09:00
@alexandear alexandear changed the title docs: specify default go version 1.17 docs: remove deprecated "go" option for staticcheck Mar 10, 2023
@alexandear
Copy link
Member Author

alexandear commented Mar 10, 2023

Removed go option from the reference. Changed PR's title and description.

gofumpt also has a similar option lang-version. Maybe, we should also remove it.

@ldez
Copy link
Member

ldez commented Mar 10, 2023

Maybe we can keep the option with only the deprecated message (no default, no description).
Like that the option is still documented for users that already use this option.

@ldez ldez added the feedback required Requires additional feedback label Mar 10, 2023
@alexandear alexandear force-pushed the docs-reference-go117 branch from 51f9218 to b140bae Compare March 10, 2023 16:56
@alexandear alexandear changed the title docs: remove deprecated "go" option for staticcheck docs: remove description for deprecated "go" option Mar 10, 2023
@alexandear
Copy link
Member Author

Removed descriptions for go and lang-version options.

@ldez ldez removed the feedback required Requires additional feedback label Mar 10, 2023
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added the topic: cleanup Related to code, process, or doc cleanup label Mar 10, 2023
@ldez ldez merged commit 28a94fd into golangci:master Mar 10, 2023
@alexandear alexandear deleted the docs-reference-go117 branch March 10, 2023 17:25
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez ldez added this to the v1.52 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants