Skip to content

doc: improve Editor Integration section #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2022
Merged

doc: improve Editor Integration section #3307

merged 4 commits into from
Nov 2, 2022

Conversation

bbkane
Copy link
Contributor

@bbkane bbkane commented Oct 21, 2022

Turn editor integration nested list of descriptions into headers and descriptions under. This facilitates linking to headers within the generated docs, is more consistent with the following Shell Completion section which uses this style, and I find it easier to read

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 21, 2022

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ldez ldez added enhancement New feature or improvement area: docs labels Oct 21, 2022
@ldez ldez changed the title Update integrations.mdx Improove Editor Integration section Oct 21, 2022
@ldez ldez changed the title Improove Editor Integration section Improve Editor Integration section Oct 21, 2022
@ldez ldez changed the title Improve Editor Integration section docs: improve Editor Integration section Oct 21, 2022
@ldez ldez changed the title docs: improve Editor Integration section doc: improve Editor Integration section Oct 21, 2022
alexandear
alexandear requested changes Oct 25, 2022
View reviewed changes
Copy link
Member

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Please consider and slightly change the code.

bbkane and others added 2 commits October 25, 2022 14:36
@bbkane @ldez
Update integrations.mdx
696de0c 
Turn editor integration nested list of descriptions into headers and descriptions under. This facilitates linking to headers within the generated docs, is more consistent with the following Shell Completion section which uses this style, and I find it easier to read
@ldez @alexandear
Apply suggestions from code review
6158573 
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
@bbkane
Copy link
Contributor Author

bbkane commented Oct 28, 2022

Thanks for updating the patch @ldez ! Anything more I can do here?

ldez
ldez approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez
Copy link
Member

ldez commented Oct 28, 2022

@alexandear can you approve?

@bombsimon bombsimon requested a review from alexandear October 29, 2022 10:36
@ldez ldez merged commit 09fb4d7 into golangci:master Nov 2, 2022
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@bbkane @SeigeC
doc: improve Editor Integration section (golangci#3307)
de3d5c7
@ldez ldez added this to the v1.51 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@alexandear alexandear Awaiting requested review from alexandear

Assignees
No one assigned
Labels
area: docs enhancement New feature or improvement
Projects
None yet
Milestone
v1.51
Development

Successfully merging this pull request may close these issues.
4 participants
@bbkane @CLAassistant @ldez @alexandear