-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add wrapcheck linter #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapcheck linter #1407
Conversation
Hey, thank you for opening your first Pull Request ! |
Looks good to me, I'll approve once you fixed the conflicts. |
Cheers for that @Nivl, have resolved the conflict. Should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@Nivl, just wondering if there is anything else that needs to be done before this can be merged? I don't have write access. Thanks! 🙂 |
Nope, let's merge this! Thanks for the PR! |
Hey, @tomarrell — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
This PR introduces the wrapcheck linter.
There is a more extensive write-up about the functionality and justification for this linter here: https://blog.tomarrell.com/post/introducing_wrapcheck_linter_for_go
The test added here is just a minimal example, there is a more extensive suite included in the repository.