Skip to content

Bump up gci to v0.2.2 #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Bump up gci to v0.2.2 #1305

merged 1 commit into from
Aug 17, 2020

Conversation

daixiang0
Copy link
Contributor

Here is the output with v0.2.1 and v0.2.2:

$ gci -d galley/pkg/config/source/kube/interfaces.go
diff -u galley/pkg/config/source/kube/interfaces.go.orig galley/pkg/config/source/kube/interfaces.go
--- galley/pkg/config/source/kube/interfaces.go.orig	2020-08-17 10:32:06.048341665 +0800
+++ galley/pkg/config/source/kube/interfaces.go	2020-08-17 10:32:06.048341665 +0800
@@ -18,7 +18,9 @@
 	"k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"
 	"k8s.io/client-go/dynamic"
 	"k8s.io/client-go/kubernetes"
-	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp" // import GKE cluster authentication plugin
+
+	//  import GKE cluster authentication plugin   <===
+	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
 	"k8s.io/client-go/rest"
 	"k8s.io/client-go/tools/clientcmd"
 )
$ gci -d galley/pkg/config/source/kube/interfaces.go
diff -u galley/pkg/config/source/kube/interfaces.go.orig galley/pkg/config/source/kube/interfaces.go
--- galley/pkg/config/source/kube/interfaces.go.orig	2020-08-17 10:31:44.708207759 +0800
+++ galley/pkg/config/source/kube/interfaces.go	2020-08-17 10:31:44.708207759 +0800
@@ -18,7 +18,9 @@
 	"k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"
 	"k8s.io/client-go/dynamic"
 	"k8s.io/client-go/kubernetes"
-	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp" // import GKE cluster authentication plugin
+
+	// import GKE cluster authentication plugin
+	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
 	"k8s.io/client-go/rest"
 	"k8s.io/client-go/tools/clientcmd"
 )

There is an extra blank in the comment, bump up version to fix it.

Signed-off-by: Xiang Dai long0dai@foxmail.com

Signed-off-by: Xiang Dai <long0dai@foxmail.com>
@daixiang0 daixiang0 merged commit e695b14 into golangci:master Aug 17, 2020
@daixiang0 daixiang0 deleted the bump branch August 17, 2020 06:30
@ldez ldez added linter: new Support new linter linter: update version Update version of linter and removed linter: new Support new linter labels Dec 7, 2020
@ldez ldez added this to the v1.31 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants